Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the broken Pachyderm tutorial link #2999

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fixed the broken Pachyderm tutorial link #2999

merged 1 commit into from
Jul 12, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Jul 12, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-9330

Description

Change the link in manifest file for Pachyderm tutorial

Screenshot 2024-07-12 at 3 03 41 PM

How Has This Been Tested?

  1. Deploy the manifest in your cluster oc apply -k manifests/rhoai/shared/apps/pachyderm -n opendatahub
  2. Verify that pachyderm tutorial redirects to correct page

Test Impact

N/A, changed url

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 requested a review from Gkrumbach07 July 12, 2024 09:42
@openshift-ci openshift-ci bot requested review from christianvogt and ppadti July 12, 2024 09:42
manaswinidas
manaswinidas approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested the access tutorial link in Pachyderm tile on Resources tab. Works fine.
Screenshot 2024-07-12 at 8 07 24 PM

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2024
Gkrumbach07
Gkrumbach07 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 60fca5e into opendatahub-io:main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manaswinidas manaswinidas manaswinidas approved these changes

@Gkrumbach07 Gkrumbach07 Gkrumbach07 approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@ppadti ppadti Awaiting requested review from ppadti

Assignees

@Gkrumbach07 Gkrumbach07

@manaswinidas manaswinidas

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnaik1 @Gkrumbach07 @manaswinidas